Add E2E wall-clock timing for store requests (GPU IPC + async data paths)#373
Draft
Copilot wants to merge 3 commits into
Draft
Add E2E wall-clock timing for store requests (GPU IPC + async data paths)#373Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Add E2E timing for submit_store to get_finished
Add E2E wall-clock timing for store requests (GPU IPC + async data paths)
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a unified end-to-end timing mechanism in
LMCacheMPWorkerAdapterthat measures true wall-clock time fromsubmit_store_request(forward thread) to whenget_finishedobserves the future resolved — capturing actual GPU copy completion, not just kernel launch time.Changes
import timeadded to standard imports_store_submit_times: dict[str, float]added toLMCacheMPWorkerAdapter.__init__to track per-request submit timestampssubmit_store_request: recordstime.perf_counter()at entry, keyed byrequest_idget_finished: whens_future.query()returnsTrue, pops the submit timestamp and emits:_store_submit_times.clear()alongside the existingstore_futures.clear()callsWhy this works for both paths
HandleTransferContext)AsyncDataTransferContext)Both paths surface a
MessagingFuturepolled inget_finished, so a single instrumentation point gives an apples-to-apples comparison. Grep[E2E-STORE]to extract timings.