Moved salutation to core and added configurable custom gender#14
Open
lukas-buergi wants to merge 2 commits into
Open
Moved salutation to core and added configurable custom gender#14lukas-buergi wants to merge 2 commits into
lukas-buergi wants to merge 2 commits into
Conversation
lukas-buergi
force-pushed
the
salutation_work
branch
from
1c02bb6 to
58debfc
Compare
lukas-buergi
force-pushed
the
salutation_work
branch
from
58debfc to
718f94f
Compare
lukas-buergi
force-pushed
the
salutation_work
branch
from
718f94f to
722d75f
Compare
Member
|
Sorry für die lange Wartezeit bis zu einer Antwort. Ich finde das einerseits sehr gut und dann will ich das gleiche Ziel doch irgendwie anders erreichen können. Wenn es nur um die Anrede geht, würde ich das Geschlecht da gleich ganz rauslassen und die Funktionalität der Anrede besser gestalten. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR goes along with hitobito/hitobito#2071, details are over there. The changes here are very minor, the gender_custom is enabled and the old binary gender too (by default).