Open
Conversation
because starting the video usually delays ~1 sec due to loading the data. Prevents an initial quick reload happening every time when a video starts.
Testextvideo3 for511
Fix a bug where video unnecessarily synchronised with higher/lower play rate
最終的にはループのダサい感じを解消すべき。
SInce 3.0 external video events are much more simplified than before. Sometimes there is only one tag with start and stop information, without any event tag at the inside.
Enlarge the inverval. replace Component with PureComponent, which massively reduces render() call.
Delete unnecessary conditions. Previously the player always plays from the start of the video when the user rewinds the player after the video play finishes, and the last event is i.e., "playbackRateChange".
This fixes a problem that did not exist <bbb3, which allows a external_videos.xml without any events in the parent tag.
- if (index) is false when index is 0. - '==' is replaced with '===' according to the npm compiler - player.primary can be undefined (but probably not anymore). Just a fail safe.
instead of setInterval
index === -1 means either the timestamp has already passed this video, or there is no events (events is an empty array). Here, it always means the latter. So this can catch the case where the user rewinds a one-stroke video before it ends.
Does not change so much...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.