Dev5.4.0 external video3 by hiroshisuga · Pull Request #39 · hiroshisuga/bbb-playback

hiroshisuga · 2025-09-28T01:56:43Z

hiroshisuga/bigbluebutton#236 is necessary.

To show the debug log, you add "?debug=true" at the end of URL.

~~Thumbnail not shown~~ -> accounts for the record_and_playback of BBB (hiroshisuga/bigbluebutton@9f3fd6e)
So far only for YouTube
Sometimes video does not stop when the video is stalled at event change (network issue?)
when the user gets back before the beginning of a video after it's already played once, the video does not start almost always. https://bbb1.pu-hiroshima.ac.jp/playback/presentation/2.3/81214bf90bf246a1b6bc81a2e7dda0d24a52e27e-1759589300011
what happens when the video starts from the middle (how it is recorded in the events.xml?)
when a video is played in twice speed, the video's time does not progress twice faster, resulting a severe time difference in the next event. (what about 1/2 speed?) -> PR 24050
relationship between handleOnReady, handleOnPlay, handleFirstPlay, and hasPlayedBefore unclear. What happens when swapping videos?

<?xml version="1.0" encoding="UTF-8"?>
<recording id="external_videos_events">
  <video start_timestamp="5.366" stop_timestamp="34.761" url="https://youtu.be/w05Q_aZKkFw">
    <event timestamp="13.172" rate="1.0" time="83.68992466585662" type="stop" playing="false"/>
    <event timestamp="14.067" rate="1.0" time="83.87994392752076" type="play" playing="true"/>
    <event timestamp="18.868" rate="1.0" time="133.10259295261238" type="stop" playing="false"/>
    <event timestamp="19.546" rate="1.0" time="133.10583792752075" type="play" playing="true"/>
    <event timestamp="23.049" rate="1.0" time="136.512921" type="stop" playing="false"/>
    <event timestamp="25.948" rate="1.0" time="136.77876492752074" type="play" playing="true"/>
    <event timestamp="32.29" rate="1.0" time="143.09781" type="stop" playing="false"/>
  </video>
</recording>

<?xml version="1.0" encoding="UTF-8"?>
<recording id="external_videos_events">
  <video start_timestamp="6.4" stop_timestamp="81.759" url="https://youtu.be/KEJGO1w-jog">
    <event timestamp="42.878" rate="2.0" time="36.239" type="playbackRateChange" playing="true"/>
    <event timestamp="42.891" rate="2.0" time="36.425" type="seek" playing="true"/>
    <event timestamp="58.087" rate="0.5" time="51.543" type="playbackRateChange" playing="true"/>
  </video>
</recording>

because starting the video usually delays ~1 sec due to loading the data. Prevents an initial quick reload happening every time when a video starts.

Testextvideo3 for511

Fix a bug where video unnecessarily synchronised with higher/lower play rate

最終的にはループのダサい感じを解消すべき。

SInce 3.0 external video events are much more simplified than before. Sometimes there is only one tag with start and stop information, without any event tag at the inside.

Enlarge the inverval. replace Component with PureComponent, which massively reduces render() call.

Delete unnecessary conditions. Previously the player always plays from the start of the video when the user rewinds the player after the video play finishes, and the last event is i.e., "playbackRateChange".

This fixes a problem that did not exist <bbb3, which allows a external_videos.xml without any events in the parent tag.

- if (index) is false when index is 0. - '==' is replaced with '===' according to the npm compiler - player.primary can be undefined (but probably not anymore). Just a fail safe.

instead of setInterval

index === -1 means either the timestamp has already passed this video, or there is no events (events is an empty array). Here, it always means the latter. So this can catch the case where the user rewinds a one-stroke video before it ends.

Does not change so much...

hiroshisuga added 30 commits June 18, 2023 21:33

Create index.js

56f7519

Update index.js

9e57645

Create styles.css

661e27b

Update index.js

b7dde04

Update image.js

c667b0f

Update index.scss

13344c3

Update config.js

95241f2

Update en.json

b177cbc

Update builder.js

a79e329

Update index.js

4889628

Update storage.js

f53c53a

Update constants.js

9f0cc6a

Update proxy.js

a61b97d

Update layout.js

1315742

Update synchronizer.js

864ae57

Update player.js

24dcc81

Update package.json

be4d031

Update en.json

6866993

Update index.js

fa9c049

Update storage.js

a4b59cc

Update index.js

377420b

Update index.js

b0cc7eb

Update index.js

0f47d89

Update builder.js

00be64e

Update constants.js

d31cad4

Update index.js

c7db68a

Update layout.js

0dd1bd7

Update player.js

61416f5

Update synchronizer.js

b20978e

Update image.js

d8dac27

hiroshisuga added 15 commits July 1, 2023 09:34

Update index.js

5bdbf15

Update index.js

3f4f70a

Update index.js

0d781b5

more simple implementation

d9d713a

Update synchronizer.js

63b82af

suppress warning of autoplay block

e1f98a8

Update index.js

4e23e34

Update index.js

09e129f

Remove 0.75, allowing 1s inconsistency

a53df84

because starting the video usually delays ~1 sec due to loading the data. Prevents an initial quick reload happening every time when a video starts.

Merge branch 'dev5.1.1_externalVideo' into testextvideo3_for511

ca82a7b

Merge pull request #35 from hiroshisuga/testextvideo3_for511

9a650ea

Testextvideo3 for511

Add files via upload

56fbf1c

Fix: sync at diff rate

fc3c8b6

Fix a bug where video unnecessarily synchronised with higher/lower play rate

Refactor orchestration

6e71656

Merge branch 'test540_diffExtVideo3' into dev5.4.0_externalVideo3

abe1b59

hiroshisuga mentioned this pull request Sep 28, 2025

Dev3.0.15 generate external_videos.xml for playing on the fly hiroshisuga/bigbluebutton#236

Open

hiroshisuga added 14 commits October 1, 2025 21:34

bump react-player to 2.16.0

60133c3

とりあえず動くバージョン

f2de2f3

最終的にはループのダサい感じを解消すべき。

Fix: error when no events in exteral_videos.xml

8741b4f

SInce 3.0 external video events are much more simplified than before. Sometimes there is only one tag with start and stop information, without any event tag at the inside.

Optimization

46e4968

Enlarge the inverval. replace Component with PureComponent, which massively reduces render() call.

Fix: Rate change works now

0dfe562

fix rate -> 1 also when the video play finishes

d27820a

Fix: play time consistency

5d6f42d

Delete unnecessary conditions. Previously the player always plays from the start of the video when the user rewinds the player after the video play finishes, and the last event is i.e., "playbackRateChange".

Fix: enable seek for a one stroke video

5b2b2f5

This fixes a problem that did not exist <bbb3, which allows a external_videos.xml without any events in the parent tag.

Remove unnecessary import

262a773

Refactor getCurrentTime

0312de9

Fix some hidden bugs

1ee04f9

- if (index) is false when index is 0. - '==' is replaced with '===' according to the npm compiler - player.primary can be undefined (but probably not anymore). Just a fail safe.

requestAnimationFrame introduced

94e5b65

instead of setInterval

state.playing -> false when swapping videos

7b4972e

Does not change so much...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev5.4.0 external video3#39

Dev5.4.0 external video3#39
hiroshisuga wants to merge 94 commits intotest540_diffExtVideo3from
dev5.4.0_externalVideo3

hiroshisuga commented Sep 28, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

hiroshisuga commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

hiroshisuga commented Sep 28, 2025 •

edited

Loading