Open
Conversation
comment why passing volume, mute, and rate by props does not work.
Since the externalvideo component does not get rerendered in the current implementation, I move all rerendering process into external-video-player.js
Look for the video url for each cycle of orchestrator...
Maybe not necessary..
Thumbnail hitchhiking started to work, but after jumping on a external video, you cannot use the primary player's slider to seek the video. But when the player enters external video from a normal slide, the slider works well. Obviously the synchronise function stops to work if the react-player is not re-rendered..need to find where the external video is synchronised with the primary player.
reverting the changes
revert the changes
because starting the video usually delays ~1 sec due to loading the data. Prevents an initial quick reload happening every time when a video starts.
Fix a bug where video unnecessarily synchronised with higher/lower play rate
add comments and change the name of drift value.
Owner
Author
|
with the recent change in https://github.com/hiroshisuga/bigbluebutton/pull/215/commits playback external movie becomes more precise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed:
hiroshisuga/bigbluebutton#215