chore: repo cleanup (remove redundant Flatpak dual-install)#31
Open
hikaps wants to merge 2 commits into
Open
Conversation
src/CMakeLists.txt installed the couchplay target twice -- once to CMAKE_INSTALL_BINDIR and once to DESTINATION bin 'for Flatpak'. Under Flatpak's cmake-ninja the prefix is /app, so CMAKE_INSTALL_BINDIR resolves to /app/bin -- identical to the hardcoded 'bin' destination -- making the second install a pure duplicate (and an AGENTS.md anti-pattern). The single standard install covers both Flatpak and system installs.
Synthesized from 4 parallel explore-agent scans (core architecture, tests/e2e, build/config/CI, scripts/conventions). Restructured into the standard sections: Project Overview, Architecture & Data Flow, Key Directories, Development Commands, Code Conventions, Important Files, Runtime/Tooling Preferences, Testing & QA. Preserves all conventions + adds the streaming architecture (StreamManager/SunshineConfig/helper CreateVirtualOutput/CreateNullSink), the container e2e harness, and the test-source-inclusion pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cleanup pass over the post-#22 tree. The codebase is genuinely clean — no orphaned sources/QML, zero TODO/FIXME cruft,
run-debug.shis a legit tracked helper. The one safe AGENTS.md anti-pattern was the duplicate binary install.Change: removed the redundant second
install(TARGETS couchplay DESTINATION bin)insrc/CMakeLists.txt. Under Flatpak's cmake-ninja the prefix is/app, soCMAKE_INSTALL_BINDIRalready resolves to/app/bin— identical to the hardcodedbindestination. The single standard install covers both Flatpak and system installs.Not done (deliberate — structural, not quick cleanup): test source inclusion (deliberate trade-off, big refactor),
qDebug()(intentional dev-output convention), missingpo/i18n (additive), blockingQThread::msleep(risky refactor), no CI linting (additive).Build-system change only; Flatpak + system install paths unchanged.