build: add explicit gcc cmake presets for linux#1663
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughCMake presets are refactored to introduce explicit GCC compiler presets ( ChangesLinux GCC Preset Refactoring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hey @achintya2k5 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1621 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
e2abaa6 to
8bdafa7
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
README.md (1)
83-90: ⚡ Quick winUse markdown backticks instead of triple quotes.
The triple quotes
'''are not standard markdown syntax for inline code. Consider using backticks for better rendering and consistency with typical markdown conventions.♻️ Proposed refactor
-# Note on Linux Presets: The standard '''linux-x64-release''' -# and '''linux-x64-debug''' presets are the recommended +# Note on Linux Presets: The standard `linux-x64-release` +# and `linux-x64-debug` presets are the recommended # defaults for local development and will automatically # use the GCC Compiler. If you are specifically testing # toolchain portability or checking CI matrix # coverage, compiler-explicit alternatives are available: -# '''linux-x64-gcc-release''' / '''linux-x64-gcc-debug''' -# (with '''clang''' variants forthcoming) +# `linux-x64-gcc-release` / `linux-x64-gcc-debug` +# (with `clang` variants forthcoming)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` around lines 83 - 90, Replace the nonstandard triple-quote inline code markers ('''...''') with Markdown backticks around the preset names so they render correctly; update occurrences for linux-x64-release, linux-x64-debug, linux-gcc-release, linux-x64-gcc-debug and the forthcoming clang variants to use `backticks` instead of triple quotes throughout the README text.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 89: Update the incorrect preset name string 'linux-gcc-release' to
'linux-x64-gcc-release' in the README where the presets list contains "#
'linux-gcc-release' / 'linux-x64-gcc-debug'"; locate that literal and replace it
so both presets consistently include the 'x64' component (e.g.,
'linux-x64-gcc-release' / 'linux-x64-gcc-debug').
---
Nitpick comments:
In `@README.md`:
- Around line 83-90: Replace the nonstandard triple-quote inline code markers
('''...''') with Markdown backticks around the preset names so they render
correctly; update occurrences for linux-x64-release, linux-x64-debug,
linux-gcc-release, linux-x64-gcc-debug and the forthcoming clang variants to use
`backticks` instead of triple quotes throughout the README text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 06ee0609-7b11-4e07-82f6-c50f9d866896
📒 Files selected for processing (3)
.github/workflows/zxc-build-library.yamlCMakePresets.jsonREADME.md
Signed-off-by: achintya2k5 <achintyasin@gmail.com>
8bdafa7 to
ccf8fb1
Compare
Description:
Introduces explicit CMake presets for GCC on Linux to improve CI clarity and toolchain robustness, while maintaining standard aliases for local development friction.
linux-x64-gcc-debugandlinux-x64-gcc-releaseexplicit CMake configure and build presetslinux-x64-debugandlinux-x64-releaseto act as thin aliases inheriting from the explicit GCC presetszxc-build-library.yamlto uselinux-x64-gcc-*so logs explicitly advertise the compilerREADME.mdbuild instructions to clarify GCC defaults and document explicit alternativesRelated issue(s):
Fixes #1621
Notes for reviewer:
Tested locally: both the explicit
linux-x64-gcc-*and aliaslinux-x64-*presets successfully configure and build the project viavcpkgandninja. CI matrices will now explicitly show the GCC compiler being exercised to prepare for future toolchain additions (e.g., Clang).Note regarding
CLAUDE.md: The original issue mentioned updatingCLAUDE.md, but I omitted that from this PR as the file does not currently exist in the repository.Checklist
Summary by CodeRabbit
Chores
Documentation