chore: remove redundant mutex lock around log4cxx warning#1655
Open
achintya2k5 wants to merge 1 commit into
Open
chore: remove redundant mutex lock around log4cxx warning#1655achintya2k5 wants to merge 1 commit into
achintya2k5 wants to merge 1 commit into
Conversation
|
Hey @achintya2k5 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1611 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
Signed-off-by: achintya2k5 <achintyasin@gmail.com>
676cd01 to
8f3af8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Remove redundant mutex lock around log4cxx warning in the network update loop. The underlying
log4cxx::Loggeris internally thread-safe, making the outermMutexlock unnecessary and a potential source of lock contention.std::unique_lockfrom the catch block inClient::scheduleNetworkUpdateRelated issue(s):
Fixes #1611
Notes for reviewer:
Built locally using the
linux-x64-debugCMake preset.Ran the full
ClientUnitTestssuite (24/24 passed). Specifically verified concurrency safety by running theNetworkUpdateThreadDoesNotDeadlock*suite; all 6 tests passed in < 1 second with 0 timeouts, confirming no regression of #1533.Checklist