Skip to content

chore: remove redundant mutex lock around log4cxx warning#1655

Open
achintya2k5 wants to merge 1 commit into
hiero-ledger:mainfrom
achintya2k5:chore/remove-redundant-logger-mutex
Open

chore: remove redundant mutex lock around log4cxx warning#1655
achintya2k5 wants to merge 1 commit into
hiero-ledger:mainfrom
achintya2k5:chore/remove-redundant-logger-mutex

Conversation

@achintya2k5

Copy link
Copy Markdown
Contributor

Description:
Remove redundant mutex lock around log4cxx warning in the network update loop. The underlying log4cxx::Logger is internally thread-safe, making the outer mMutex lock unnecessary and a potential source of lock contention.

Related issue(s):

Fixes #1611

Notes for reviewer:
Built locally using the linux-x64-debug CMake preset.
Ran the full ClientUnitTests suite (24/24 passed). Specifically verified concurrency safety by running the NetworkUpdateThreadDoesNotDeadlock* suite; all 6 tests passed in < 1 second with 0 timeouts, confirming no regression of #1533.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@achintya2k5 achintya2k5 requested review from a team as code owners May 17, 2026 16:41
@achintya2k5 achintya2k5 requested a review from gsstoykov May 17, 2026 16:41
@github-actions

github-actions Bot commented May 17, 2026

Copy link
Copy Markdown

Hey @achintya2k5 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- All commits have verified GPG signatures. Locked and loaded!


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- Linked to #1611 (assigned to you).


🎉 All checks passed! Your PR is ready for review. Great job!

@github-actions github-actions Bot added the status: needs revision The pull request requires changes from the author before it can be reviewed or merged label May 17, 2026
Signed-off-by: achintya2k5 <achintyasin@gmail.com>
@achintya2k5 achintya2k5 force-pushed the chore/remove-redundant-logger-mutex branch from 676cd01 to 8f3af8d Compare May 17, 2026 16:45
@github-actions github-actions Bot added status: needs review The pull request is ready for maintainer review and removed status: needs revision The pull request requires changes from the author before it can be reviewed or merged labels May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs review The pull request is ready for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Beginner]: Remove redundant mMutex hold around mLogger.warn in Client::scheduleNetworkUpdate

1 participant