Milestone 1 complete: Kayak removed, HttpListener in place — follow-on clean-up

[Copilot]

PR #120 fully achieved the first milestone (Kayak → HttpListener). This PR confirms that and addresses the immediate follow-on hygiene items surfaced during the review.

Changes

• README — replace deprecated WebClient.DownloadString with HttpClient.GetStringAsync + async/await; fix "Eample" typo
• RequestHandlerFactory.ClearHandlers — remove dead no-op that allocated a List<RequestHandler> and discarded it without assigning
• FileResponseBody.GetBytes — fix CA2022: FileStream.Read can return fewer bytes than requested; replace with ReadExactly (available since .NET 7)

// Before — partial read possible
fileStream.Read(buffer, 0, (int)fileInfo.Length);

// After — guaranteed full read
fileStream.ReadExactly(buffer, 0, (int)fileInfo.Length);

Original prompt

Review the code for next steps. Analyse if the first milestone has been achieved

---

⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.

[Copilot]

Pull request overview

Follow-on cleanup after the Kayak → HttpListener milestone: removes dead code, fixes a file-read correctness issue, and modernizes README sample code.

Changes:

• Update README sample to use HttpClient.GetStringAsync with async/await, and fix a typo (“Eample” → “Example”).
• Remove a no-op RequestHandlerFactory.ClearHandlers() method.
• Replace FileStream.Read with ReadExactly in FileResponseBody.GetBytes() to ensure full-buffer reads.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
README.md	Modernizes sample HTTP call to async HttpClient and fixes a typo.
src/HttpMock/RequestHandlerFactory.cs	Removes unused/broken public API method (ClearHandlers).
src/HttpMock/FileResponseBody.cs	Uses ReadExactly to avoid partial reads when loading file responses.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Removing the public RequestHandlerFactory.ClearHandlers() method is a breaking change for any external consumers that may be calling it (even if it was previously a no-op). Consider keeping the method as a backwards-compatible wrapper (e.g., delegating to _requestProcessor.ClearHandlers()), marking it [Obsolete], and removing it in the next major version instead of deleting it outright.

[Copilot]

new HttpClient() is created inline and never disposed in the example. Even in sample code this can encourage patterns that lead to socket exhaustion; prefer a single reused HttpClient instance or a using/using var around it in the snippet.

Suggested change

	string result = await new HttpClient().GetStringAsync("http://localhost:9191/endpoint");
	using var httpClient = new HttpClient();
	string result = await httpClient.GetStringAsync("http://localhost:9191/endpoint");

[Copilot]

Since buffer is already sized to the file length, consider calling ReadExactly using buffer.Length (and avoiding repeated (int)fileInfo.Length casts). This removes a potential mismatch if the file size changes between allocation and read, and keeps the code simpler.

Suggested change

	fileStream.ReadExactly(buffer, 0, (int)fileInfo.Length);
	int length = (int)fileInfo.Length;
	fileStream.ReadExactly(buffer, 0, buffer.Length);
	int length = buffer.Length;