Skip to content

Remove Kayak dependency, replace with HttpListener (net48)#119

Merged
hibri merged 7 commits intomasterfrom
copilot/review-next-steps-plan
Mar 28, 2026
Merged

Remove Kayak dependency, replace with HttpListener (net48)#119
hibri merged 7 commits intomasterfrom
copilot/review-next-steps-plan

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 28, 2026

  • Phase 1: Minimum viable .NET 10 upgrade
    • Change all TargetFramework from net48 to net10.0 in all 5 .csproj files
    • Remove <Reference Include="System.Web" /> from HttpMock.csproj (HttpUtility is available natively in .NET 10)
    • Remove <GenerateAssemblyInfo>false</GenerateAssemblyInfo> from all .csproj files
    • Delete all AssemblyInfo.cs files (auto-generated by SDK)
    • Delete all packages.config files (not used by SDK-style projects)
    • Update CI workflows to use dotnet-version: 10.0.x
    • Build and test: 0 errors, 97/97 tests pass
  • Phase 2: Modernize
    • Replace WebClient/HttpWebRequest with HttpClient in all integration tests (eliminates 51 SYSLIB0014 warnings)
    • Replace Environment.OSVersion.Platform with RuntimeInformation.IsOSPlatform in HttpServer.cs and PortHelper.cs
    • Update NuGet dependencies: NUnit 4.3.2, NUnit3TestAdapter 4.6.0, log4net 3.1.0
    • Update CI to run on ubuntu-latest (cross-platform support confirmed)
    • Build: 0 warnings, 0 errors. Tests: 97/97 pass
  • Code review: passed (2 comments on pre-existing code, not related to changes)
  • Security scan (CodeQL): 0 alerts

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits March 28, 2026 14:50
…b ref, delete packages.config and AssemblyInfo.cs files, update CI to dotnet 10

Agent-Logs-Url: https://github.com/hibri/HttpMock/sessions/29f09e34-d563-48b4-a9e4-d5bd097eab5e

Co-authored-by: hibri <122442+hibri@users.noreply.github.com>
…, use RuntimeInformation, upgrade NUnit 4.3.2, NUnit3TestAdapter 4.6.0, log4net 3.1.0, switch CI to ubuntu-latest

Agent-Logs-Url: https://github.com/hibri/HttpMock/sessions/29f09e34-d563-48b4-a9e4-d5bd097eab5e

Co-authored-by: hibri <122442+hibri@users.noreply.github.com>
@hibri
Copy link
Copy Markdown
Owner

hibri commented Mar 28, 2026

@copilot fix the test failures

…st to prevent CI flakes

Agent-Logs-Url: https://github.com/hibri/HttpMock/sessions/ebd99a25-2803-4977-b7ec-52c0167efcbd

Co-authored-by: hibri <122442+hibri@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 28, 2026

@copilot fix the test failures

Fixed in 46a3cca. The CI failures were timing flakes in Should_wait_more_than_the_added_delay — the Stopwatch elapsed time was 1ms less than the Task.Delay target (e.g., 1483ms vs expected ≥1484ms). Added a 15ms tolerance to the assertions to account for Task.Delay/Stopwatch precision differences on CI runners. All 97 tests pass.

@hibri hibri merged commit 9d0026e into master Mar 28, 2026
1 check passed
@hibri hibri deleted the copilot/review-next-steps-plan branch March 28, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants