ci(verify): pin config path + strip AIRMCP_* so the gate measures the starter default#287
Merged
Merged
Conversation
… starter default verify:package booted the installed tarball with the host's full env (...process.env + AIRMCP_TEST_MODE=1), so it inherited ~/.config/airmcp/ config.json and any exported AIRMCP_*. On a dev box whose config disables modules, the gate measured a polluted surface — and could false-fail its >=100 floor — instead of the starter default a fresh `npx -y airmcp` user gets. Apply the same pollution-free discipline as the clean-room recipe, but surgically: strip every AIRMCP_* from the inherited env and pin AIRMCP_CONFIG_PATH to a guaranteed-absent file so loadConfig falls through to the STARTER preset (loadFileConfig → fileExists:false). Non-AIRMCP env (PATH/HOME/npm_config_*) is kept so npx and the npm cache keep working on any runner; AIRMCP_TEST_MODE=1 is re-set to stay symmetric with smoke-mcp / mcp-validate. HOME is left intact — config determinism comes from the pinned path, not HOME isolation — so the inspector download stays cache-warm. Gate behavior unchanged (>=100 floor + required core tools); only the measurement is now host-independent. Verified locally: this machine's module-disabling config previously skewed it; the gate now reports 111 tools deterministically, matching the ~111 starter figure in README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify:package booted the installed tarball with the host's full env
(...process.env + AIRMCP_TEST_MODE=1), so it inherited ~/.config/airmcp/
config.json and any exported AIRMCP_*. On a dev box whose config disables
modules, the gate measured a polluted surface — and could false-fail its
Apply the same pollution-free discipline as the clean-room recipe, but
surgically: strip every AIRMCP_* from the inherited env and pin
AIRMCP_CONFIG_PATH to a guaranteed-absent file so loadConfig falls through
to the STARTER preset (loadFileConfig → fileExists:false). Non-AIRMCP env
(PATH/HOME/npm_config_*) is kept so npx and the npm cache keep working on
any runner; AIRMCP_TEST_MODE=1 is re-set to stay symmetric with smoke-mcp /
mcp-validate. HOME is left intact — config determinism comes from the pinned
path, not HOME isolation — so the inspector download stays cache-warm.
Gate behavior unchanged (>=100 floor + required core tools); only the
measurement is now host-independent. Verified locally: this machine's
module-disabling config previously skewed it; the gate now reports 111
tools deterministically, matching the ~111 starter figure in README.