Skip to content

perf: faster encode_url and decode_url #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevenjoezhang merged 3 commits into from
Jan 2, 2026
Merged

perf: faster encode_url and decode_url #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dbd2df
perf: faster `encode_url` and `decode_url`
D-Sketon Oct 3, 2025
3721771
feat: rm regexp
D-Sketon Oct 13, 2025
7d51793
Merge branch 'master' into perf/3.3.0-2
stevenjoezhang Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/decode_url.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ import { parse, format } from 'url';
import { unescape } from 'querystring';

const decodeURL = (str: string) => {
if (parse(str).protocol) {
const index = str.indexOf(':');
if (index < 0) {
return unescape(str);
}
if (parse(str.slice(0, index + 1)).protocol) {

@SukkaW SukkaW Jan 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url.parse is only to determine if the given input is "somewhat" a valid URL (because try { new URL() } catch {} is extremely slow, so we want to avoid new URL() to throw at all cost).

const parsed = new URL(str);

// Exit if input is a data url
Expand Down
6 changes: 5 additions & 1 deletion lib/encode_url.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ import { parse, format } from 'url';
import { unescape } from 'querystring';

const encodeURL = (str: string) => {
if (parse(str).protocol) {
const index = str.indexOf(':');
if (index < 0) {
return encodeURI(unescape(str));
}
if (parse(str.slice(0, index + 1)).protocol) {
const parsed = new URL(str);

// Exit if input is a data url
Expand Down