test: expect feed charset headers#367
Merged
Merged
Conversation
stevenjoezhang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Update the
feed - atomandfeed - rssunit tests to expect the UTF-8 charset added by #365.Why
#365 intentionally changed feed responses from bare
application/atom+xml/application/rss+xmltoapplication/atom+xml; charset=utf-8/application/rss+xml; charset=utf-8, but the existing tests still asserted the old headers. That made unrelated PRs, including #366, fail CI after rebasing onto the fixed behavior.Validation
node node_modules/eslint/bin/eslint.js .node node_modules/mocha/bin/mocha test/index.js --grep 'feed -'node node_modules/mocha/bin/mocha test/index.js --grep 'change port setting' --invertFull
test/index.jswas also run once; only the pre-existing fixed-port testchange port settingfailed locally because macOS ControlCenter was already listening on0.0.0.0:5000.