Skip to content

deps: update jj-lib to 0.41#42

Merged
hewigovens merged 1 commit into
mainfrom
h/jj-lib-0.41-ci
May 7, 2026
Merged

deps: update jj-lib to 0.41#42
hewigovens merged 1 commit into
mainfrom
h/jj-lib-0.41-ci

Conversation

@hewigovens
Copy link
Copy Markdown
Owner

Summary

Updates the Rust core dependency set for jj-lib 0.41 and gix 0.83 while keeping sha2 aligned on 0.10.9.

Details

  • Adapts revset and evolution traversal to jj-lib's stream-based APIs while keeping the UniFFI surface synchronous for these non-Send local streams.
  • Updates working-copy mutation locking for the async jj-lib API.
  • Updates gitignore handling for the new GitIgnoreFile API and preserves ignored-parent-directory behavior for watcher filtering.
  • Avoids including the separate GPUI/Nix flake.nix work in this PR.

Validation

  • cargo check --workspace
  • just build
  • just test
  • just lint

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the jj-lib and gix dependencies, necessitating a migration from synchronous iterators to asynchronous streams for repository operations such as walking predecessors and evaluating revsets. The ignore matching logic in working_copy_ignore.rs was also refactored to utilize RepoPath types instead of raw strings. Review feedback identified a regression in error handling within immutable_commit_ids where a single error now aborts the entire operation, and suggested an optimization to reduce string allocations during directory key reconstruction in the ignore matcher.

Comment thread crates/jayjay-core/src/repo/log.rs Outdated
Comment thread crates/jayjay-core/src/repo/working_copy_ignore.rs Outdated
@hewigovens hewigovens marked this pull request as ready for review May 7, 2026 22:34
@hewigovens hewigovens merged commit bb314db into main May 7, 2026
4 checks passed
@hewigovens hewigovens deleted the h/jj-lib-0.41-ci branch May 7, 2026 23:13
hewigovens added a commit that referenced this pull request May 7, 2026
- Rebased onto post-PR #42 main (jj-lib 0.41 + gix 0.83). Cargo.lock churn means
  this run is cold again; the new key populates the cache for future runs.
- Drop the `tags: v*` trigger from appimage.yml. We're not shipping the
  AppImage as a release asset yet (no Linux icons/menus); workflow_dispatch
  only for now.
- Tighten verbose comments in flake.nix to one-liners.
hewigovens added a commit that referenced this pull request May 8, 2026
…mments; drop tag trigger

- Rebased onto post-#42 main (jj-lib 0.41 + gix 0.83). Cargo.lock churn means
  the cache key shifts; this run repopulates.
- Bump actions/upload-artifact v4 -> v5 and cache-nix-action v6 -> v7. v6 was
  failing tar exit 2 on cache restore; v7 reworked the tarball strategy. Both
  ride Node 24 (v4/v6 were deprecated Node 20).
- Drop the `tags: v*` trigger; we're not shipping the AppImage as a release
  asset yet (no Linux icons/menus). workflow_dispatch only.
- Tighten verbose comments in flake.nix to one-liners.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant