Update of PCI scanning process in fdt#425
Open
duanyu-yu wants to merge 1 commit intohermit-os:mainfrom
Open
Conversation
duanyu-yu
force-pushed
the
pci
branch
8 times, most recently
from
ac50cda to
3eda3ca
Compare
mkroening
requested changes
Feb 21, 2025
Member
mkroening
left a comment
mkroening
left a comment
There was a problem hiding this comment.
Some initial comments. I have not looked at the details yet.
| let pci_node = fdt.begin_node("pci")?; | ||
| fdt.property_string("device_type", "pci")?; | ||
|
|
||
| // TODO: Address cells and size cells should be 3 and 2 respectively. 1 and 1 are only used for compatibility with devicetree output tool. |
Contributor
Author
There was a problem hiding this comment.
Due to the fdt output in the command line, the cells have to be 1 and 1 for now. But this is not standard. If we want a standard device tree, we have to configure the output tool first and change the cells respectively. So the question is do we need a standard device tree?
duanyu-yu
force-pushed
the
pci
branch
3 times, most recently
from
e99639b to
362269f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea needs to be checked to ensure it is correct. Still have to fix the CI errors.