hproxy: add HTTP server timeouts and control body limits#1079
Open
marcopeereboom wants to merge 1 commit into
Open
hproxy: add HTTP server timeouts and control body limits#1079marcopeereboom wants to merge 1 commit into
marcopeereboom wants to merge 1 commit into
Conversation
Both the proxy and control HTTP servers had zero timeouts, allowing slowloris-style attacks to hold connections open indefinitely and exhaust file descriptors. Add configurable ReadHeaderTimeout, ReadTimeout, WriteTimeout, and ServerIdleTimeout to both servers. The control add and remove endpoints decoded JSON from r.Body without http.MaxBytesReader, allowing unbounded body reads to cause OOM. Add a configurable MaxControlBodySize limit (default 1 MiB). All new values are exposed as HPROXY_* environment variables.
github-actions
Bot
added
area: docs
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the proxy and control HTTP servers had zero timeouts, allowing slowloris-style attacks to hold connections open indefinitely and exhaust file descriptors. The control add and remove endpoints decoded JSON from
r.BodywithoutMaxBytesReader, allowing unbounded body reads to cause OOM.Adds configurable
ReadHeaderTimeout,ReadTimeout,WriteTimeout,ServerIdleTimeout, andMaxControlBodySizeto the hproxy Config, with defaults andHPROXY_*environment variable wiring incmd/hproxyd.Addresses #695.