tbc: guard MsgTx dispatch on MempoolEnabled#1077
Open
marcopeereboom wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
area: tbc
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
marcopeereboom
force-pushed
the
marco/mempool-nil-guard
branch
from
87aec1c to
573320f
Compare
When MempoolEnabled is false, s.mempool is nil. handleGeneric dispatched MsgTx to handleTx unconditionally, which dereferences s.mempool. An unsolicited P2P transaction message crashes the process. Gate the dispatch on s.cfg.MempoolEnabled, matching the pattern already used by handleInv's mempool block.
marcopeereboom
force-pushed
the
marco/mempool-nil-guard
branch
from
573320f to
956ba2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
MempoolEnabledis false,s.mempoolis nil.handleGenericdispatchedMsgTxtohandleTxunconditionally, which dereferencess.mempool— an unsolicited P2P transaction message crashes the process.Gate the dispatch on
s.cfg.MempoolEnabled, matching the pattern already used byhandleInv's mempool block.