feat: add dry-run flag for sync and apply by yxxhero · Pull Request #1050 · helmfile/helmfile

yxxhero · 2023-09-30T10:38:22Z

xiaomudk · 2023-10-11T14:57:24Z

@yxxhero Thanks for your hard work, it would be better if you add some test cases.

yxxhero · 2023-10-12T12:06:13Z

@yxxhero Thanks for your hard work, it would be better if you add some test cases.

got it.

stale · 2023-10-28T09:33:09Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

felipecrs · 2023-10-28T14:40:34Z

This would be an useful feature.

stale · 2023-11-12T03:39:20Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2023-11-26T17:37:27Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

balagurrr · 2023-11-30T18:15:00Z

yep, it's very useful feature

hoangelos

If you can't finish the unitest of this, I'd do it, because it's creating some big problems not having access to the dry-run.

hoangelos · 2023-12-14T20:09:08Z

cmd/apply.go

 	f.StringVar(&applyOptions.PostRenderer, "post-renderer", "", `pass --post-renderer to "helm template" or "helm upgrade --install"`)
 	f.StringArrayVar(&applyOptions.PostRendererArgs, "post-renderer-args", nil, `pass --post-renderer-args to "helm template" or "helm upgrade --install"`)
 	f.StringVar(&applyOptions.Cascade, "cascade", "", "pass cascade to helm exec, default: background")
+	f.StringVar(&applyOptions.DryRyn, "dry-run", "", "pass dry-run to helm exec")


Isn't this a typo?

hoangelos · 2023-12-14T20:09:23Z

cmd/sync.go

 	f.StringVar(&syncOptions.PostRenderer, "post-renderer", "", `pass --post-renderer to "helm template" or "helm upgrade --install"`)
 	f.StringArrayVar(&syncOptions.PostRendererArgs, "post-renderer-args", nil, `pass --post-renderer-args to "helm template" or "helm upgrade --install"`)
 	f.StringVar(&syncOptions.Cascade, "cascade", "", "pass cascade to helm exec, default: background")
+	f.StringVar(&syncOptions.DryRyn, "dry-run", "", "pass dry-run to helm exec")


Isn't DryRyn a typo?

hoangelos · 2023-12-14T20:10:00Z

pkg/config/sync.go

 	// Cascade '--cascade' to helmv3 delete, available values: background, foreground, or orphan, default: background
 	Cascade string
+	// DryRun is for helm dry-run flag
+	DryRyn string


hoangelos · 2023-12-14T20:10:11Z

pkg/config/sync.go

+
+// DryRun returns dry-run flag
+func (t *SyncImpl) DryRun() string {
+	return t.SyncOptions.DryRyn


yxxhero · 2023-12-14T22:41:19Z

If you can't finish the unitest of this, I'd do it, because it's creating some big problems not having access to the dry-run.

Yeah. Please feel free to do that.

yxxhero · 2023-12-16T06:38:53Z

@hoangelos ping

hoangelos · 2023-12-18T02:30:23Z

@yxxhero I can't push the UnitTest to this branch. It's saying I don't have rights to do that

MREMCDBAFC2C:helmfile peter.halliday$ git push upstream add-dry-run-flag-for-sync-and-apply
ERROR: Permission to helmfile/helmfile.git denied to hoangelos.
fatal: Could not read from remote repository.

yxxhero · 2023-12-18T02:31:54Z

@hoangelos oh. you can create a new PR for this.

hoangelos · 2023-12-18T02:42:21Z

@yxxhero I've doing a separate PR to push into the branch this PR is on.

#1235

pkg/state/helmx_test.go

felipecrs · 2024-03-01T19:26:57Z

@yxxhero just a question, what would happen with hooks in your implementation? Would they still execute in dry run mode?

yxxhero · 2024-03-02T00:44:11Z

@felipecrs good question. I need to think more.

felipecrs · 2024-03-02T00:50:10Z

Some ideas when dry run is on:

Don't run any hooks
Don't run release-level hooks, but still run global hooks
Run hooks, but provide some template variable so that hooks can identify whether they are running in dry run mode or not

yxxhero · 2024-03-02T23:49:26Z

@felipecrs thanks so much. good ideas.

yxxhero · 2024-05-28T13:36:24Z

Some ideas when dry run is on:

Don't run any hooks

Don't run release-level hooks, but still run global hooks

Run hooks, but provide some template variable so that hooks can identify whether they are running in dry run mode or not

I will follow the point 3. thanks so much.

Signed-off-by: yxxhero <aiopsclub@163.com>

achetronic · 2024-11-29T16:24:33Z

hi @yxxhero how is the status of this?

yxxhero · 2024-11-30T07:11:13Z

hi @yxxhero how is the status of this?

WIP

achetronic · 2024-11-30T14:42:44Z

@yxxhero Hey, more data to throw:

I just discovered that in apply command, there is ALREADY a diff-args flag, so I executed:

helmfile -f helmfile.yaml apply --selector name={{ .RELEASE_NAME }} --include-transitive-needs --interactive --diff-args '--dry-run=server' {{ .EXTRA_ARGS }}

And Bitnami's mongoDB helm chart, that is one of the most problematic ones, started to work fine and smooth. So my question then is: what is the point of the the feature if it can be solved simply passing "--diff-args" ?

yxxhero marked this pull request as ready for review September 30, 2023 10:38

yxxhero requested review from itscaro, mumoshu and xiaomudk as code owners September 30, 2023 10:38

stale bot added the wontfix This will not be worked on label Oct 28, 2023

yxxhero removed the wontfix This will not be worked on label Oct 28, 2023

yxxhero force-pushed the add-dry-run-flag-for-sync-and-apply branch from 59bb9a8 to 9b2e9b5 Compare October 29, 2023 02:41

stale bot added the wontfix This will not be worked on label Nov 12, 2023

yxxhero removed the wontfix This will not be worked on label Nov 12, 2023

yxxhero force-pushed the add-dry-run-flag-for-sync-and-apply branch from 9b2e9b5 to 44eba38 Compare November 12, 2023 12:24

stale bot added the wontfix This will not be worked on label Nov 26, 2023

yxxhero removed the wontfix This will not be worked on label Nov 26, 2023

yxxhero force-pushed the add-dry-run-flag-for-sync-and-apply branch from 44eba38 to 7f77237 Compare November 26, 2023 23:55

yxxhero added the in progress label Nov 30, 2023

hoangelos reviewed Dec 14, 2023

View reviewed changes

yxxhero closed this Dec 18, 2023

yxxhero reopened this Dec 18, 2023

yxxhero force-pushed the add-dry-run-flag-for-sync-and-apply branch from b06eff8 to 9135c51 Compare December 22, 2023 23:20

yxxhero commented Jan 3, 2024

View reviewed changes

pkg/state/helmx_test.go Outdated Show resolved Hide resolved

yxxhero force-pushed the add-dry-run-flag-for-sync-and-apply branch from 73b60f0 to 7b8468c Compare February 10, 2024 04:27

yxxhero marked this pull request as ready for review February 10, 2024 04:27

yxxhero force-pushed the add-dry-run-flag-for-sync-and-apply branch 7 times, most recently from 2fba764 to fb7c54e Compare February 13, 2024 10:57

yxxhero mentioned this pull request May 25, 2024

diff is breaking for specific checks performed by bitnami/common databus23/helm-diff#460

Open

yxxhero force-pushed the add-dry-run-flag-for-sync-and-apply branch from fb7c54e to 3b73c6f Compare May 25, 2024 14:39

yxxhero force-pushed the add-dry-run-flag-for-sync-and-apply branch from 3b73c6f to 6752cfe Compare May 28, 2024 13:36

yxxhero and others added 8 commits June 2, 2024 15:03

fix conflicts

279d7de

Signed-off-by: yxxhero <aiopsclub@163.com>

Fix typos and ask unittest (#1235)

4b3ad24

Signed-off-by: yxxhero <aiopsclub@163.com>

fix tests

b5095c0

Signed-off-by: yxxhero <aiopsclub@163.com>

Restrict version of helm, and default dryRun. (#1265)

ac25cc5

Signed-off-by: yxxhero <aiopsclub@163.com>

fix issues

c710e2b

Signed-off-by: yxxhero <aiopsclub@163.com>

fix issues

cc3202e

Signed-off-by: yxxhero <aiopsclub@163.com>

fix more issue

61b4199

Signed-off-by: yxxhero <aiopsclub@163.com>

add runinfo

2ebdf9a

Signed-off-by: yxxhero <aiopsclub@163.com>

yxxhero force-pushed the add-dry-run-flag-for-sync-and-apply branch from bac765c to 2ebdf9a Compare June 2, 2024 07:04

Uh oh!

Conversation

yxxhero commented Sep 30, 2023

Uh oh!

xiaomudk commented Oct 11, 2023

Uh oh!

yxxhero commented Oct 12, 2023

Uh oh!

stale bot commented Oct 28, 2023

Uh oh!

felipecrs commented Oct 28, 2023

Uh oh!

stale bot commented Nov 12, 2023

Uh oh!

stale bot commented Nov 26, 2023

Uh oh!

balagurrr commented Nov 30, 2023

Uh oh!

hoangelos left a comment

Choose a reason for hiding this comment

Uh oh!

hoangelos Dec 14, 2023

Choose a reason for hiding this comment

Uh oh!

hoangelos Dec 14, 2023

Choose a reason for hiding this comment

Uh oh!

hoangelos Dec 14, 2023

Choose a reason for hiding this comment

Uh oh!

hoangelos Dec 14, 2023

Choose a reason for hiding this comment

Uh oh!

yxxhero commented Dec 14, 2023

Uh oh!

yxxhero commented Dec 16, 2023

Uh oh!

hoangelos commented Dec 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yxxhero commented Dec 18, 2023

Uh oh!

hoangelos commented Dec 18, 2023

Uh oh!

Uh oh!

felipecrs commented Mar 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yxxhero commented Mar 2, 2024

Uh oh!

felipecrs commented Mar 2, 2024

Uh oh!

yxxhero commented Mar 2, 2024

Uh oh!

yxxhero commented May 28, 2024

Uh oh!

achetronic commented Nov 29, 2024

Uh oh!

yxxhero commented Nov 30, 2024

Uh oh!

achetronic commented Nov 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hoangelos commented Dec 18, 2023 •

edited

Loading

felipecrs commented Mar 1, 2024 •

edited

Loading

achetronic commented Nov 30, 2024 •

edited

Loading