(Enhancement): Analytics - Updated regex for entitiy-detection logic of phone_number v2

[ganeshhaptik]

JIRA Ticket Number AN-4218

JIRA TICKET: https://hello-haptik.atlassian.net/browse/AN-4218

Description of change

• Did load testing:

import re
import timeit


def older_regex():
    phone_number_format_regex = r'[-(),.+\s{}]+'
    test_numbers = [
        "(123) 456-7890",
        "+1 123-456-789",
        "123456789",
        "1234567890123"
    ]
    for number in test_numbers:
        re.match(phone_number_format_regex, number)


def simple_regex():
    phone_number_format_regex = r'[0-9\-\(\)\.\+\s]{9,12}'
    test_numbers = [
        "(123) 456-7890",
        "+1 123-456-789",
        "123456789",
        "1234567890123"
    ]
    for number in test_numbers:
        re.match(phone_number_format_regex, number)

def complex_regex():
    phone_number_format_regex = r'^(?:\+?\d{1,3})?[-.\s]?\(?\d{1,4}\)?[-.\s]?\d{1,4}[-.\s]?\d{1,4}$'
    test_numbers = [
        "(123) 456-7890",
        "+1 123-456-789",
        "123456789",
        "1234567890123"
    ]
    for number in test_numbers:
        re.match(phone_number_format_regex, number)

# Benchmark both regex patterns
old_time = timeit.timeit(older_regex, number=1000000)
simple_time = timeit.timeit(simple_regex, number=1000000)
complex_time = timeit.timeit(complex_regex, number=1000000)

print(f"Old regex time: {old_time}")
print(f"Simple regex time: {simple_time}")
print(f"Complex regex time: {complex_time}")

• Yesterday's regex r'[-(),.+\s{}]{9,12}' - didn't worked for ticket number, so had to update it.

• updated it to support numbers, r'[0-9-().+\s]{9,12}'

• Later while testing found out Refactor few variables, add defaults to config and add documentation for datastore environment variables #2 (new one) is not working for numbers of 13 digits long.

• so updated it to support to range 9 to 12 only so 13 digit number will not be considered as a phone number,

• but to handle 13 digits, it became complex - like r'^(?:+?\d{1,3})?[-.\s]?(?\d{1,4})?[-.\s]?\d{1,4}[-.\s]?\d{1,4}$'

• but complexity to handle just case is not helpful so need to ignore 13 digit case, but before that did load testing on 1 million entries,

• found out time in Refactor few variables, add defaults to config and add documentation for datastore environment variables #2 and java install #5 is double, so we need to go with Refactor few variables, add defaults to config and add documentation for datastore environment variables #2 (simpler one but it won't handle 13 digits if no brackets given), and I think it should be fine.

• Slack thread for discussion on AGCT Group - https://haptik.slack.com/archives/C04NKEXCAHH/p1727158979642939?thread_ts=1727070015.417459&cid=C04NKEXCAHH

• Slack thread for adding testcases in Chat-bot NER - https://haptik.slack.com/archives/G01NG4CSL8P/p1727159738581209?thread_ts=1727080081.909739&cid=G01NG4CSL8P

[haptik-deployment]

👍 No lint errors found.

[sonarqubecloud]

Please retry analysis of this Pull-Request directly on SonarCloud

[haptik-deployment]

UNIT TESTS HAVE PASSED... Good To Merge

[codecov]

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 40.46%. Comparing base (e9734de) to head (6e90ab4).
Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ors/pattern/phone_number/phone_number_detection.py	11.11%	8 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #557      +/-   ##
===========================================
- Coverage    40.48%   40.46%   -0.02%     
===========================================
  Files           81       81              
  Lines         9468     9475       +7     
===========================================
+ Hits          3833     3834       +1     
- Misses        5635     5641       +6     

Flag	Coverage Δ
	40.46% <11.11%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.