Skip to content

[Sonic Frontiers] Two minor documentation changes to libraries #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Icedude907 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Sonic Frontiers] Two minor documentation changes to libraries #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24fd7fc
[Sonic Frontiers] BlackboardBattle: mapped QuickCyloopCharging
Icedude907 Nov 4, 2023
9c6ec69
[Sonic Frontiers] GameManager: Documented 1.40 Location of `_sigGameM…
Icedude907 Nov 4, 2023
89b3d9d
PR: Incorporate review changes
Icedude907 Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Source/Sonic Frontiers/Libraries/BlackboardBattle.hmm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ Library "BlackboardBattle" by "Hyper & ĐeäTh" does "Provides access to `app::p
/// The value of the Quick Cyloop gauge.
/// </summary>
[FieldOffset(0xB8)] public float QuickCyloopAmount;

/// <summary>
/// Is the Quick Cyloop gauge Active (false) or Charging (true).
/// </summary>
[FieldOffset(0xF1)] public bool QuickCyloopCharging;
Copy link
Member

@hyperbx hyperbx Nov 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm that this is a bool and not a short, as the constructor for this class suggests there's a 16-bit integer at offset 0xF0. This could be flags instead of a single boolean, but that could also be a compiler optimisation.

Copy link
Author

@Icedude907 Icedude907 Nov 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0xF0 seems to also be flags - for instance bit 6 (*0xF0 & 0b0100_0000) seems to be 'isPhantomRushActive' so it could be a short

However I have no idea how to confirm this - I'm a complete outsider to this game's reverse engineering efforts.

}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion Source/Sonic Frontiers/Libraries/GameManager.hmm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Library "GameManager" by "Hyper, ĐeäTh & Sajid"
[FieldOffset(0x210)] public ObjectMoveArray<long> GameStepListeners;
}

/* 0x140C478D8 */
/* 0x140D30788 */
private static long _sigGameManagerSingleton = (long)ScanSignature
(
"\x48\x89\x2D\xCC\xCC\xCC\xCC\x8D\x75\x20",
Expand Down