-
Notifications
You must be signed in to change notification settings - Fork 46
- [x] done #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
A-Tione
wants to merge
1
commit into
hcsp:master
Choose a base branch
from
A-Tione:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
- [x] done #154
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,10 @@ | ||
| package com.github.hcsp.functional; | ||
|
|
||
| import java.rmi.server.ObjID; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.Random; | ||
| import java.util.concurrent.atomic.AtomicInteger; | ||
| import java.util.function.Supplier; | ||
|
|
||
| public class RefactorToSupplier { | ||
|
|
@@ -19,30 +21,23 @@ public static void main(String[] args) { | |
| // 请尝试使用函数式接口Supplier对三个方法进行重构,消除冗余代码 | ||
| // 并尽量尝试使用lambda表达式和方法引用来传递参数 | ||
| public static List<Object> create(Supplier<Object> supplier) { | ||
| return null; | ||
| } | ||
|
|
||
| public static List<Object> createObjects() { | ||
| List<Object> result = new ArrayList<>(); | ||
| for (int i = 0; i < 10; i++) { | ||
| result.add(new Object()); | ||
| result.add(supplier.get()); | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| public static List<Object> createObjects() { | ||
| return create(Object::new); | ||
| } | ||
|
|
||
| public static List<Object> createStrings() { | ||
| List<Object> result = new ArrayList<>(); | ||
| for (int i = 0; i < 10; i++) { | ||
| result.add("" + i); | ||
| } | ||
| return result; | ||
| AtomicInteger i = new AtomicInteger(0); | ||
| return create(() -> "" + i.getAndIncrement()); | ||
| } | ||
|
|
||
| public static List<Object> createRandomIntegers() { | ||
| List<Object> result = new ArrayList<>(); | ||
| for (int i = 0; i < 10; i++) { | ||
| result.add(randomInt()); | ||
| } | ||
| return result; | ||
| return create(RefactorToSupplier::randomInt); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return 值周围不必要的小括号。用一个空格分隔非空白字符。