Clarify that a blocked channel will discard results#129
Open
codesoap wants to merge 1 commit intohashicorp:mainfrom
Open
Clarify that a blocked channel will discard results#129codesoap wants to merge 1 commit intohashicorp:mainfrom
codesoap wants to merge 1 commit intohashicorp:mainfrom
Conversation
The documentation previously did not clarify, that results are immediately discarded, if the receiving channel is not accepting entries. This is now emphasized and a remedy is suggested more directly.
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
abhijeetviswa
approved these changes
Apr 1, 2025
abhijeetviswa
left a comment
abhijeetviswa
left a comment
There was a problem hiding this comment.
Thanks for the PR. This looks good to me!
mukeshjc
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to suggest a clarification in the documentation of the
QueryandQueryContextfunctions, because I had misunderstood it. Before this PR, the documentation of both functions stated the following:When using the library, I made sure that the entries were indeed read from the channel in a timely manner, but some results were sporadically missing. After reading the code of the library, I realized that results are immediately discarded, if the receiving side is not quite as fast as the sending side. I think the documentation should put more emphasis on this behavior.