Skip to content

cmdrunner: release process handle in _pidAlive to avoid pidfd leak #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ritikrajdev merged 2 commits into from
Apr 29, 2026
+5 −0
Merged

cmdrunner: release process handle in _pidAlive to avoid pidfd leak #378

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36c0fd6
cmdrunner: release process handle in _pidAlive to avoid pidfd leak
texasich Apr 22, 2026
8382575
cmdrunner: ignore proc.Release error to satisfy errcheck
texasich Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/cmdrunner/process_posix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ import (
func _pidAlive(pid int) bool {
proc, err := os.FindProcess(pid)
if err == nil {
// On Linux with Go 1.23+, FindProcess opens a pidfd which must be
// released or it leaks an FD on every call. Release errors are
// intentionally ignored; the handle is short-lived and there's
// nothing actionable to recover from a release failure.
defer func() { _ = proc.Release() }()
err = proc.Signal(syscall.Signal(0))
}

Expand Down