Add 404 error slack notifications#3013
Open
rmainwork wants to merge 6 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rmainwork
requested review from
a team and
williamdalessandro
and removed request for
a team
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Instana configuration to notify a Slack channel when the website sees a high volume of 404 responses, aligning alerting with the monitoring setup managed in this repo’s Terraform.
Changes:
- Introduces Terraform variables for Slack alerting configuration and 404 alert thresholds/time windows.
- Adds an Instana Slack alerting channel resource and wires it into a new website 404 alert rule with tag filtering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| terraform/variables.tf | Adds inputs for Slack channel/app/workspace identifiers and 404 alert tuning parameters. |
| terraform/instana.tf | Creates an Instana Slack alert channel and a 404 volume website alert using that channel and a generated tag filter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rmainwork
force-pushed
the
rm/add-404-error-slack-notifications
branch
from
f950e20 to
60e41d0
Compare
rmainwork
force-pushed
the
rm/add-404-error-slack-notifications
branch
from
08ec987 to
0f7a704
Compare
Notify slack channel for RUM errors
We aren't focusing on 5xx alerts in dev portal for now. Instead, focus only on 404 alerts within a specified time window
By using asset type (and getting rid of a bunch of string manipulation) - we can greatly simplify the alert configuration
Require the slack ID to be explicitly provided either via local tfvars, or via vars in TFC. This prevents accidental notification of the wrong channel by forcing this info to be explicitly provided
Apparently sets can introduce potential diff/ID issues. Since there's only one id here anyway, we can just use a simple list. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
rmainwork
force-pushed
the
rm/add-404-error-slack-notifications
branch
from
0f7a704 to
9ad90cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Relevant links
🗒️ What
Add slack notifications for 404 errors detected by Instana.
🧪 Testing
.envasNEXT_PUBLIC_INSTANA_WEBSITE_MONITORING_KEYnpm run build; npm run serve)