[WIP] Populate website ID to vercel with Terraform#3010
Draft
rmainwork wants to merge 9 commits into
Draft
Conversation
This does not currently replace DataDog entirely, but the intent is to run them in parallel for an A/B comparison
We can't action exceptions from dependencies anyway, so it makes sense to exclude them from monitoring entirely. This is currently being done in DataDog alerts, but we can actually just not ingest them into Instana at all and keep the clutter out.
It turns out that the produciton Instana does not support clickops configuration. Therefore the configuration via Terraform has beend one instead.
- Sensitive variables like production instana API token now live in HCP terraform backend - All terraform and provider related code now extracted to terraform.tf to reduce clutter
This just helps to maintain a clean separation of concerns
The word "this" isn't a terribly useful name for what the resource is. Let's pick something better
This is a value that needs to be generated by Instana and is best populated by Terraform to the env vars in Vercel rather than being hard coded here.
In order to expose environment variables to client, they must be prefixed with `NEXT_PUBLIC_*` otherwise they will be redacted for safety reasons. In this instance, it's okay for this value to be public.
Since this value is generated by Instana when the resource is created, we can use Terraform to populate it to Vercel dynamically
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this value is generated by Instana when the resource is created, we can use Terraform to populate it to Vercel dynamically
🗒️ What
Use Terraform to populate the auto generated website key from Instana to Vercel. That way we don't have to copy and paste it and keep the secret in sync.
This code was LLM generated and is (currently, at time of writing) untested. This PR serves as a POC/WIP and should not be merged/deployed without a proper review.
🤷 Why
Terraform is aware of this value and outputs it at the end of the run. We can have it populate the value into Vercel to keep Vercel in sync with the correct value. It doesn't change very often, so this shouldn't need ot be done regularly, but it's still nice to not have to worry about keeping the two in sync.