Skip to content

.ToLower() -> .ToLowerInvariant() #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benoitjadinon wants to merge 2 commits into
base: master
Choose a base branch
from
Open

.ToLower() -> .ToLowerInvariant() #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73dc901
.ToLower() -> .ToLowerInvariant()
Feb 16, 2017
f686621
ToLowerInvariant() on Android as well
benoitjadinon Feb 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/KeyChain.Net.XamarinAndroid/KeyChainHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@ public KeyChainHelper(Func<Context> context, string keyStoreFileProtectionPasswo
/// <param name="keyName">Keyname/username.</param>
public string GetKey (string keyName)
{
var wantedAlias = MakeAlias(keyName, _serviceId).ToLower();
var wantedAlias = MakeAlias(keyName, _serviceId).ToLowerInvariant();

var aliases = _androidKeyStore.Aliases ();
while (aliases.HasMoreElements) {
var alias = aliases.NextElement ().ToString ();
if (alias.ToLower().Contains(wantedAlias))
if (alias.ToLowerInvariant().Contains(wantedAlias))
{
var e = _androidKeyStore.GetEntry (alias, _passwordProtection) as KeyStore.SecretKeyEntry;
if (e != null)
Expand Down
12 changes: 6 additions & 6 deletions src/KeyChain.Net.XamarinIOS/KeyChainHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ private static SecStatusCode DeletePassword (string username, string serviceId,
}

// Querying is case sesitive - we don't want that.
username = username.ToLower ( );
serviceId = serviceId.ToLower ( );
username = username.ToLowerInvariant ( );
serviceId = serviceId.ToLowerInvariant ( );

// Query and remove.
SecRecord queryRec = new SecRecord ( SecKind.GenericPassword ) { Service = serviceId, Label = serviceId, Account = username, Synchronizable = synchronizable };
Expand Down Expand Up @@ -128,8 +128,8 @@ private static SecStatusCode SetPassword ( string username, string password, str
}

// Querying is case sesitive - we don't want that.
username = username.ToLower ( );
serviceId = serviceId.ToLower ( );
username = username.ToLowerInvariant ( );
serviceId = serviceId.ToLowerInvariant ( );

// Don't bother updating. Delete existing record and create a new one.
DeletePassword ( username, serviceId, synchronizable );
Expand Down Expand Up @@ -173,8 +173,8 @@ private static string GetPassword ( string username, string serviceId, bool sync
}

// Querying is case sesitive - we don't want that.
username = username.ToLower ( );
serviceId = serviceId.ToLower ( );
username = username.ToLowerInvariant ( );
serviceId = serviceId.ToLowerInvariant ( );

SecStatusCode code;
// Query the record.
Expand Down