feat(search): add since/before/include_body params to search_emails#1
Open
harcek wants to merge 1 commit into
Open
feat(search): add since/before/include_body params to search_emails#1harcek wants to merge 1 commit into
harcek wants to merge 1 commit into
Conversation
- since/before: date filters passed directly to IMAP server for efficiency - include_body: body search is now opt-in (default: subject+sender only) Body search is expensive on large mailboxes; when enabled without a since date, automatically constrains to the last 90 days to prevent timeouts - orFields typed as Record<string, string>[] to fix TS union type error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream implementation always included
{ body: query }in the OR criteria. On large mailboxes this causes IMAP body scans to time out.Changes:
include_body(defaultfalse). Without it, only subject and sender are searched — fast on any mailbox size.include_body=trueand nosinceis provided, a 90-day window is automatically applied to bound the scan.sinceandbeforeparams (ISO 8601) for explicit date filtering on all searches.orFieldstype from union toRecord<string, string>[]to satisfy TypeScript strict mode.Depends on codefuturist#28.
Tested against Gmail and other IMAP providers. No regressions on existing tools.