added callback option#4
Open
godspeedelbow wants to merge 3 commits into
Open
Conversation
- in case you want other fallback behavior than going to app store
Author
|
I wasn't aware that when I make subsequent commits after creating a pull request, Github just adds them to the PR. Anyways, this PR gets a bit convoluted like this |
Owner
|
Great suggestion. Haven't been able to verify, but code looks like it should do the job :) if (settings.callback) {
timeout = setTimeout(settings.callback, settings.delay);
} else if (settings.fallback) {
timeout = setTimeout(openAppStore(Date.now()), settings.delay);
} |
Author
|
I had it like that before but I figured I didn't want to overrule current behavior. But now that that's an option, how about we let
|
Owner
|
Yep, sounds good! |
Owner
|
The |
Author
|
Yeah, good idea! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our situation we don't want the user to go the app store but we rather provide custom callback behavior that's called when the app is not found
I also added a trailing
;afterendin the android url because our Titanium app goes haywire without it.Also, switched
packageandschemefor same reason