Skip to content
This repository was archived by the owner on Feb 27, 2023. It is now read-only.

Minor changes for Zoom#24

Closed
akki-ng wants to merge 12 commits into
halilb:masterfrom
NeoGrowth-Credit-Pvt-Limited:master
Closed

Minor changes for Zoom#24
akki-ng wants to merge 12 commits into
halilb:masterfrom
NeoGrowth-Credit-Pvt-Limited:master

Conversation

@akki-ng

@akki-ng akki-ng commented Oct 5, 2016

Copy link
Copy Markdown

This will support zoom of image. And ActivityIndicator has been added as AndroidProgressBar is deprecated. Readme.md changes can be ignored as they were meant for internal audience.

@7kfpun

7kfpun commented Oct 6, 2016

Copy link
Copy Markdown

Android only?

@akki-ng

akki-ng commented Oct 6, 2016

Copy link
Copy Markdown
Author

Yes, for android only. I've tested these changes on Android and it works fine.

@7kfpun

7kfpun commented Oct 6, 2016

Copy link
Copy Markdown

I tested on iOS, the images could not show.

@akki-ng

akki-ng commented Oct 6, 2016

Copy link
Copy Markdown
Author

Okay, I'll check these on iOS and do updates if needed. Meanwhile can you confirm it to work on Android as I did not find any issues for Android.

[Tip]

While installing this module we must install the below module too in MainApplication, Settings.gradle, Build.gradle too.

https://www.npmjs.com/package/react-native-image-zoom

@akki-ng

akki-ng commented Oct 6, 2016

Copy link
Copy Markdown
Author

Did you put necessary entries into the concerned files for react-native-image-zoom ?

@ksti

ksti commented Oct 8, 2016

Copy link
Copy Markdown

I'v already add the supporting of zooming photo in this PR, it works with both Android and iOS. Although it hasn't been accepted yet. Why don't you try this?:)

@akki-ng

akki-ng commented Oct 8, 2016

Copy link
Copy Markdown
Author

@ksti Sure, I will try this soon. Thanks.

@akki-ng

akki-ng commented Oct 14, 2016

Copy link
Copy Markdown
Author

@ksti I've found an issue with this change. Please ignore the pull request for now.

@akki-ng akki-ng closed this Oct 14, 2016
@akki-ng akki-ng reopened this Oct 14, 2016
@akki-ng akki-ng closed this Oct 14, 2016
@akki-ng

akki-ng commented Oct 14, 2016

Copy link
Copy Markdown
Author

Close as new pull request is being made.

@akki-ng akki-ng reopened this Oct 14, 2016
@akki-ng akki-ng closed this Oct 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants