Skip to content

Comments

Split test and test_system in CI#1000

Merged
skyfallwastaken merged 2 commits intomainfrom
faster-ci
Feb 24, 2026
Merged

Split test and test_system in CI#1000
skyfallwastaken merged 2 commits intomainfrom
faster-ci

Conversation

@skyfallwastaken
Copy link
Member

No description provided.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 24, 2026

Greptile Summary

This PR splits the combined test job into two separate jobs (test and test_system) to enable parallel execution, which should improve CI performance. The unit/integration tests now run in the test job, while browser-based system tests run in the test_system job.

Key changes:

  • test job runs bin/rails test and Swagger doc validation
  • test_system job runs bin/rails test:system with Chrome/Bun/Vite setup
  • Both jobs use independent Postgres services, avoiding database conflicts
  • Removed 68 lines of commented-out code for cleaner configuration
  • Tests can now run in parallel, reducing overall CI execution time

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes properly split test execution into parallel jobs without introducing any functional issues. Both jobs have independent Postgres services, appropriate environment variables, and correct test commands. The refactoring improves CI performance while maintaining test coverage.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/ci.yml Split test job into separate test and test_system jobs to enable parallel execution, improving CI speed. Removed commented-out code.

Last reviewed commit: 99d3f3c

@skyfallwastaken skyfallwastaken merged commit df9e4d8 into main Feb 24, 2026
14 checks passed
@skyfallwastaken skyfallwastaken deleted the faster-ci branch February 24, 2026 12:57
@DragonSenseiGuy
Copy link
Contributor

grr u took the 1000th PR

@skyfallwastaken
Copy link
Member Author

LMAO i just realised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants