Fix descriptor search range in retrieveDescriptors()#387
Merged
h2zero merged 1 commit intoh2zero:masterfrom Dec 3, 2025
Merged
Fix descriptor search range in retrieveDescriptors()#387h2zero merged 1 commit intoh2zero:masterfrom
h2zero merged 1 commit intoh2zero:masterfrom
Conversation
Owner
|
Thanks! Looks like I broke this in 2.0.0 and hasn't been noticed until now. Could you please rebase this so only the changes required are in the PR? |
The previous implementation incorrectly used the service's end handle when searching for descriptors, which caused it to retrieve descriptors from subsequent characteristics as well. This fix calculates the correct end handle by finding the next characteristic's handle and using (next_handle - 1) as the search limit. This ensures only descriptors belonging to the current characteristic are retrieved. Fixes incorrect descriptor retrieval when multiple characteristics exist in the same service.
e865c64 to
f4846e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
NimBLERemoteCharacteristic::retrieveDescriptors()function incorrectly uses the service's end handle (getRemoteService()->getEndHandle()) as the search range limit when discovering descriptors.This causes the following bug:
Example scenario:
Before fix: Searching descriptors for Characteristic A returns A1, A2, and B1 ❌
After fix: Searching descriptors for Characteristic A returns only A1 and A2 ✅
Solution
This PR fixes the issue by:
next_characteristic_handle - 1as the end handle for descriptor searchChanges Made
retrieveDescriptors()to iterate through service characteristicsendHandlebased on the next characteristic's handleTesting
This fix correctly handles:
Files Changed
src/NimBLERemoteCharacteristic.cpp(+18 lines, -2 lines)