Conversation
h2zero
force-pushed
the
refactor-notify
branch
2 times, most recently
from
47a5a55 to
f07e777
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the notification and indication handling in NimBLE to improve efficiency and throughput by tracking client subscription state locally and sending data directly rather than relying on the stack to read values.
Key Changes
- Adds client subscription state tracking via
SubPeerEntrystructure inNimBLECharacteristicwith flags for subscription type and security status - Refactors
sendValue()to send notifications/indications directly using copied data with retry logic (up to 10ms) for buffer allocation failures - Introduces new
getCharacteristicByHandle()lookup method and streamlines event handling inNimBLEServerfor subscribe and notify_tx events
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/NimBLEServer.h | Adds getCharacteristicByHandle() method declaration and reorganizes private method declarations |
| src/NimBLEServer.cpp | Implements characteristic lookup, fixes typo and bug in getPeerInfo(), refactors subscribe/notify_tx event handling to use new subscription tracking |
| src/NimBLECharacteristic.h | Defines SubPeerEntry struct for tracking subscriber state, adds subscription management methods, and new onStatus() callback overload with NimBLEConnInfo |
| src/NimBLECharacteristic.cpp | Refactors notify/indicate to send data directly, implements subscription request processing and peer status updates with critical section protection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
h2zero
force-pushed
the
refactor-notify
branch
from
f07e777 to
8c8d11c
Compare
This refactors the handling of sending notifications and indications for greater efficiency. * Adds client subscription state tracking to NimBLECharacteristic rather than relying on the stack. * Notifications/indications are now sent directly, no longer calling the callback to read the values. This avoids delays and flash writes in the stack, allowing for greater throughput.
Adds a new overloaded callback to NimBLECharacteristicCallbacks for the notification/indication onStatus method that provides a NimBLEConnInfo reference.
h2zero
force-pushed
the
refactor-notify
branch
from
8c8d11c to
cfa584c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the handling of sending notifications and indications for greater efficiency.