Conversation
Owner
|
Thanks! |
Contributor
Author
|
@h2zero how does this one look? |
h2zero
reviewed
Sep 28, 2025
docs/Usage_tips.md
Outdated
|
|
||
| When commands are sent to the stack from a different core they can experience delays in execution. | ||
| This library detects this and invokes the esp32 IPC to reroute these commands through the correct core but this also increases overhead. | ||
| This library is threadsafe. It detects calls from other cores and invokes the esp32 IPC to reroute these commands through the correct core but this also increases overhead. |
Owner
There was a problem hiding this comment.
This is no longer relevant, the IPC is no longer used, so just removing this will be best to prevent any confusion.
Contributor
Author
There was a problem hiding this comment.
@h2zero so we should remove the Nimble thread section entirely:
## Put BLE functions in a task running on the NimBLE stack core
When commands are sent to the stack from a different core they can experience delays in execution.
This library is threadsafe. It detects calls from other cores and invokes the esp32 IPC to reroute these commands through >
Therefore it is highly recommended to create tasks for BLE to run on the same core, the macro `CONFIG_BT_NIMBLE_PINNED_TO_>
<br/>
and then add a
## Threadsafety
This library is threadsafe.
Thoughts?
Contributor
Author
There was a problem hiding this comment.
@h2zero thoughts on what we might put here? Would like to wrap this one up
Owner
There was a problem hiding this comment.
I think that is all that is needed, maybe extend it with attributes can be manipulated freely or something like that.
chmorgan
force-pushed
the
cmm_threadsafe_docs
branch
from
e366930 to
4fb4ee9
Compare
chmorgan
force-pushed
the
cmm_threadsafe_docs
branch
from
4fb4ee9 to
a6289fc
Compare
h2zero
approved these changes
Oct 20, 2025
Contributor
Author
|
@h2zero I can't merge this even though its approved, its all you :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.