Open
Conversation
Endlich gefixed. Funktioniert jetzt wieder See merge request yho/esp-nimble-cpp!1
Merge wieder rein. Änderungen an 'onRead' und 'onWrite' See merge request yho/esp-nimble-cpp!2
Fix: OnWriteEventArgs - String is cut short if it contains a '\0' See merge request yho/esp-nimble-cpp!3
Owner
|
I like this idea. It doesn't need to be a breaking change, the new callbacks can be added as an overload in addition to the originals. |
Author
|
You're right about that. I will take a look at that option |
Author
|
Works for me now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR has some breaking changes and shouldn't be included before Version 3.0
The goal if this change is to give the user a bit more posibilities when it comes to what excactly is send to the other device. But looking forwar into the future, the adding of specific
EventArgsto the event parameters give the option to easily add more options to the events, without a breaking change.By now I included the event args for the
onReadandonWriteevents. They give the options to either send custom data back to the device or (in case ofonWrite) to not save the data that was received. AdditionallyonWritenow gets the old and the new data, so that the user has both.