Open
Conversation
DONE:
1. Add support for specifying the repo in the composition script, and supporting build-system updates, and validate the previous scripts still work.
TODO:
2. Validate that the external repo download and usage works.
3. Update `img` to `src` and enable it to not just have the form of two nested directories (i.e. "x.y"), but also a single subdir (i.e. "x"), or no directory (in the case that a repo is the single component).
FUTURE FEATURES:
I won't be able to get to these soon, but they are desirable.
- Add external library and interface repo support.
This is more challenging as it requires more build system logic as dependencies on libraries/interfaces are specified in the build system, not in the composition scripts.
Demonstrated with `external_hello_world.toml`, and the `github.com/gparmer/hello_world/` component.
DONE:
1. Add support for specifying the repo in the composition script, and supporting build-system updates, and validate the previous scripts still work.
2. Validate that the external repo download and usage works.
TODO:
3. Update `img` to `src` and enable it to not just have the form of two nested directories (i.e. "x.y"), but also a single subdir (i.e. "x"), or no directory (in the case that a repo ish.
FUTURE FEATURES:
I won't be able to get to these soon, but they are desirable.
- Enable the composition scripts to be referenced in github repos, rather than only in local files.
- Add external library and interface repo support.
This is more challenging as it requires more build system logic as dependencies on libraries/interfaces are specified in the build system, not in the composition scripts.
Merge branch 'main' into external_packages
gparmer
commented
Jun 27, 2022
| src/components/lib/libc/musl-1.2.0/include/asm-generic/ | ||
| src/components/lib/libc/musl-1.2.0/include/linux/ | ||
| src/components/lib/libc/musl-1.2.0/include/sys/queue.h No newline at end of file | ||
| src/components/lib/libc/musl-1.2.0/include/sys/queue.h |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of this Pull Request (PR)
Add description here.
Intent for your PR
Choose one (Mandatory):
Reviewers (Mandatory):
@betahxy @WenyuanShao If you're interested. Mostly Rust and build system updates.
Can
And it will run the component defined in https://github.com/gparmer/hello_world
The composition scripts have the
repodirective:Existing scripts should run as expected.
Code Quality
As part of this pull request, I've considered the following:
Style:
Code Craftsmanship: