Conversation
[why] While RVO is guaranteed and we will get warnings about pessimizations the c++17 new optional NRVO is warned on only on request (except on mcvc). To get optimal code we of course want to benefit from NRVO optimizations. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
soerengrunewald
approved these changes
Feb 26, 2025
Collaborator
soerengrunewald
left a comment
soerengrunewald
left a comment
There was a problem hiding this comment.
I would prefer to split the commit into adding the warning to meson and fixing it.
Aside from that 👍
Member
Author
I'm not sure if anything will be gained with splitting this already small commit into two tiny commits. Whatever ;) TNX for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[why]
While RVO is guaranteed and we will get warnings about pessimizations the c++17 new optional NRVO is warned on only on request (except on mcvc).
To get optimal code we of course want to benefit from NRVO optimizations.