feat(helm): support optional image registry in template rendering#142
Open
liglig999 wants to merge 1 commit into
Open
feat(helm): support optional image registry in template rendering#142liglig999 wants to merge 1 commit into
liglig999 wants to merge 1 commit into
Conversation
Owner
|
Hi @liglig999 thanks for the PR but why would you want to do this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To automatically update images, I added the registry in front of the image and set the registry default to empty.
This leaves me with an extra / in front of it since there is no check to see if the registry is filled.