Permit to add additional volumes for sidecar containers in statefulset.yaml#13
Open
fgionghi wants to merge 1 commit into
Open
Permit to add additional volumes for sidecar containers in statefulset.yaml#13fgionghi wants to merge 1 commit into
fgionghi wants to merge 1 commit into
Conversation
|
Is there anything still left to be done before this feature can be added? |
santiagon610
approved these changes
Oct 29, 2024
santiagon610
left a comment
Contributor
There was a problem hiding this comment.
LGTM - if you're adding a feature, could you bump the minor version of Chart.yaml please?
|
Perhaps some documentation should also be added as this changes the available values? |
Owner
|
It's possible the contributor might no longer be active. Someone can submit the PR, otherwise, I can also add the changes myself. |
It seems they are no longer active. Would you mind adding the changes to resolve this? |
|
What's the status on this PR? Do we need someone to submit a new PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using vaultwarden-backup as a sidecar container, but it also needs to mount a second volume for its configuration. At the moment I can't do it with your chart.
I achived that with the little modification I'm proposing
Then, in my values.yaml I'm using it as I would do in a normal statefulset: