Skip to content

Permit to add additional volumes for sidecar containers in statefulset.yaml#13

Open
fgionghi wants to merge 1 commit into
guerzon:mainfrom
fgionghi:additionalVolumes
Open

Permit to add additional volumes for sidecar containers in statefulset.yaml#13
fgionghi wants to merge 1 commit into
guerzon:mainfrom
fgionghi:additionalVolumes

Conversation

@fgionghi

@fgionghi fgionghi commented Mar 9, 2023

Copy link
Copy Markdown

I'm using vaultwarden-backup as a sidecar container, but it also needs to mount a second volume for its configuration. At the moment I can't do it with your chart.

I achived that with the little modification I'm proposing
Then, in my values.yaml I'm using it as I would do in a normal statefulset:

additionalVolumes:
  volumes:
    - configMap:
        name: vaultwarden-backup-rclone-config
      name: vaultwarden-backup-rclone-config

@vincentscode

Copy link
Copy Markdown

Is there anything still left to be done before this feature can be added?

@santiagon610 santiagon610 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - if you're adding a feature, could you bump the minor version of Chart.yaml please?

@vincentscode

Copy link
Copy Markdown

Perhaps some documentation should also be added as this changes the available values?

@guerzon

guerzon commented Oct 30, 2024

Copy link
Copy Markdown
Owner

It's possible the contributor might no longer be active. Someone can submit the PR, otherwise, I can also add the changes myself.

@vincentscode

Copy link
Copy Markdown

It's possible the contributor might no longer be active. Someone can submit the PR, otherwise, I can also add the changes myself.

It seems they are no longer active. Would you mind adding the changes to resolve this?

@pb4162

pb4162 commented Jun 17, 2025

Copy link
Copy Markdown

What's the status on this PR? Do we need someone to submit a new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants