Skip to content

Log GetClient errors with proxy identity and connspec #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riccardo-perotti merged 3 commits into from
Apr 17, 2026
Merged

Log GetClient errors with proxy identity and connspec #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
119cebf
Log GetClient errors with proxy identity and connspec
riccardo-perotti Apr 17, 2026
1ae0663
Replace stale CircleCI config with GitHub Actions workflow
riccardo-perotti Apr 17, 2026
21e9da4
Trigger CI checks
riccardo-perotti Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions .circleci/config.yml
View file
Open in desktop

This file was deleted.

17 changes: 17 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Build and Vet scamp-go

on:
push:

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.26'
- name: Build
run: go build ./...
- name: Vet
run: go vet ./...
10 changes: 8 additions & 2 deletions scamp/requester.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,14 @@ func MakeJSONRequest(
var clients []*Client
for _, serviceProxy := range serviceProxies {
if serviceProxy != nil {
client, err := serviceProxy.GetClient()
if err != nil || client == nil {
client, clientErr := serviceProxy.GetClient()
if clientErr != nil {
Error.Printf("GetClient failed for %s (%s): %s", serviceProxy.Ident(), serviceProxy.ConnSpec(), clientErr)
err = clientErr
continue
}
if client == nil {
Error.Printf("GetClient returned nil client for %s (%s)", serviceProxy.Ident(), serviceProxy.ConnSpec())
continue
}

Expand Down
Loading