Skip to content

Remove unused cloudformation parameter from image copier stack #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philmcmahon merged 4 commits into from
Apr 13, 2026
Merged

Remove unused cloudformation parameter from image copier stack #1801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
215493e
Support overriding the kms key used by image copier via a cloudformat…
philmcmahon Mar 13, 2026
45cc6c5
Revert "Support overriding the kms key used by image copier via a clo…
philmcmahon Mar 26, 2026
c172792
Remove Kms key parameter
philmcmahon Mar 26, 2026
c4a9f7a
Fix snapshots
philmcmahon Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions cdk/lib/__snapshots__/image-copier-lambda.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@ exports[`the lambda stack matches the snapshot 1`] = `
"Description": "The SNS topic to subscribe to",
"Type": "String",
},
"KmsKeyArn": {
"Default": "",
"Description": "Override the default KMS key if required",
"Type": "String",
},
},
"Resources": {
"HousekeepingLambda": {
Expand Down
6 changes: 0 additions & 6 deletions cdk/lib/image-copier-lambda.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ export class ImageCopierLambda extends GuStack {
'deploy-tools-dist',
);

new CfnParameter(this, 'KmsKeyArn', {
description: 'Override the default KMS key if required',
type: 'String',
default: '',
});

const kmsKeyArn = Fn.importValue('amigo-imagecopier-key');

const housekeepingTopicParam = new CfnParameter(
Expand Down
Loading