Open
Conversation
DJCordhose
commented
Apr 25, 2017
- why router when you only have one route?
- why you no typescript or no flow?
- redux installed but not used, instead I see setState quite a lot
- service is not common in react, but this looks like a valid use case for it
Owner
|
Thanks for taking the time Oliver.
|
Author
|
Cool, I can help with either TypeScript or Flow. All you need to do is to decide which one you like better: TL'DR: TypeScript has the better tooling and seems more mature, but Flow still lives in the Babel world and is easier to integrate into an existing project. It also has the more powerful type system. |
Author
|
Also you can generate propTypes from Flow types using a babel plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.