returning nil is destructive and breaks stuff#5
Open
orikad wants to merge 1 commit into
Open
Conversation
Owner
|
What's destructive about it? What does it break? I would note that setting it hidden will, in fact, not work as currently implemented. SBIconController manages its own visible state for the page control (toggled in places such as the app switcher and folders) and so this will only work temporarily. |
Author
|
While it may be argued that using SBIconController for those uses is better, SBIconListPageControl may be used for querying how many home screen pages are available or what is the current page. Just returning nil breaks those sort of uses of SBIconListPageControl. |
Owner
|
My response: don't use it for that, then. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so just use the hidden property instead?