Security node auto rebuild for mutiple operations #908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilt automatically Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
…ild first one automatically Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
| ); | ||
| } | ||
|
|
||
| private Set<UUID> getRootNetworkWhereNotHasToBeRebuilt(UUID studyUuid, UUID nodeUuid) { |
Contributor
There was a problem hiding this comment.
Change this function's name
EstherDarkish
approved these changes
Jan 9, 2026
Contributor
EstherDarkish
left a comment
EstherDarkish
left a comment
There was a problem hiding this comment.
Tests OK, some remarks.
Comment on lines
606
to
608
| public boolean isRootOrConstructionNode(UUID nodeUuid) { | ||
| return self.getNode(nodeUuid, null).getType().equals(NodeType.ROOT) || isConstructionNode(nodeUuid); | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe use
getNodeEntity(parentNodeId).getType() == NodeType.ROOT
like below ?
Comment on lines
1276
to
1299
| // 1️⃣ Ancêtres de node1 | ||
| Set<UUID> ancestorsOfNode1 = new HashSet<>(); | ||
| NodeEntity current = getNodeEntity(node1Uuid).getParentNode(); | ||
|
|
||
| while (current != null) { | ||
| ancestorsOfNode1.add(current.getIdNode()); | ||
| current = current.getParentNode(); | ||
| } | ||
|
|
||
| // 2️⃣ Remontée depuis node2 | ||
| current = getNodeEntity(node2Uuid).getParentNode(); | ||
| while (current != null) { | ||
| UUID currentId = current.getIdNode(); | ||
|
|
||
| // node1 est ancêtre de node2 | ||
| if (currentId.equals(node1Uuid)) { | ||
| return List.of(node1Uuid); | ||
| } | ||
|
|
||
| // ancêtre commun ≠ relation hiérarchique directe → on ignore | ||
| current = current.getParentNode(); | ||
| } | ||
|
|
||
| // 3️⃣ Vérifier l’inverse SANS rebalayer tout |
Contributor
There was a problem hiding this comment.
Clean those ChatGPT slop comments : remove the emoticons, special chars (≠, →, etc), and translate them in english.
| @Transactional | ||
| public void buildFirstLevelChildren(@NonNull UUID studyUuid, @NonNull UUID parentNodeUuid, @NonNull UUID rootNetworkUuid, @NonNull String userId) { | ||
| List<NodeEntity> firstLevelChildren = networkModificationTreeService.getChildren(parentNodeUuid); | ||
| long builtNodesUpToQuota = getBuiltNodesUpToQuota(studyUuid, rootNetworkUuid, userId); |
Contributor
There was a problem hiding this comment.
When we reach the quota, some of the childrens are built but not all, and we do not have a warning message. Maybe see with the PO what we should do about that ?
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Many operations (delete modification, disable modification, ...) will invalidate current node
For security node only, this will rebuild the current node after the operation is over