Skip to content

Introduce the recently added character Nicole to the roster#565

Merged
gridhead merged 1 commit into
gridhead:mainfrom
Ank-22:nicole
Jun 20, 2026
Merged

Introduce the recently added character Nicole to the roster#565
gridhead merged 1 commit into
gridhead:mainfrom
Ank-22:nicole

Conversation

@Ank-22

@Ank-22 Ank-22 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Introduce the recently added character Nicole to the roster

Fixes #536

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Ank-22, your pull request is larger than the review limit of 150000 diff characters

@Ank-22

Ank-22 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

@sdglitched, Please check. All issues should be fixed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new character, Nicole, to the system. The changes include adding her image assets to the back, face, name, and wish resource files, defining her character class with specific stats (5-star Pyro Catalyst), registering her in the character module and CharName enum, and adding corresponding test cases to verify her stats at various levels. No review comments were provided, and there is no feedback to address.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@gridhead gridhead left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality checks are failing.

@Ank-22

Ank-22 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

@gridhead Please review

@Ank-22 Ank-22 requested a review from gridhead June 8, 2026 22:31
@Ank-22

Ank-22 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Please review it, thx :)

@gridhead gridhead self-assigned this Jun 20, 2026
@gridhead gridhead added this to the Luna VII milestone Jun 20, 2026
@gridhead gridhead added the enhancement New feature or request label Jun 20, 2026
Signed-off-by: Ankit Sinha <ankitsinha.221199@gmail.com>

@gridhead gridhead left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for working on this issue!

@gridhead gridhead merged commit 282fe66 into gridhead:main Jun 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the recently added character Nicole to the GI Loadouts roster

2 participants