Introduce the recently added character Lohen to the roster#562
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @gridhead, your pull request is larger than the review limit of 150000 diff characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new character, Lohen, along with their asset definitions, character data, and unit tests. The feedback highlights that the newly added entries for Lohen in the resource files (back.qrc, face.qrc, name.qrc, wish.qrc) and the CharName enum are out of alphabetical order and should be placed after 'lisa' to maintain consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| <file>imgs/char/back/lauma.webp</file> | ||
| <file>imgs/char/back/layla.webp</file> | ||
| <file>imgs/char/back/linnea.webp</file> | ||
| <file>imgs/char/back/lohen.webp</file> |
There was a problem hiding this comment.
The entry for lohen.webp is out of alphabetical order. It should be placed after lisa.webp (line 67) to maintain proper alphabetical sorting.
| <file>imgs/char/face/lauma.webp</file> | ||
| <file>imgs/char/face/layla.webp</file> | ||
| <file>imgs/char/face/linnea.webp</file> | ||
| <file>imgs/char/face/lohen.webp</file> |
There was a problem hiding this comment.
The entry for lohen.webp is out of alphabetical order. It should be placed after lisa.webp (line 67) to maintain proper alphabetical sorting.
| <file>imgs/char/name/lauma.webp</file> | ||
| <file>imgs/char/name/layla.webp</file> | ||
| <file>imgs/char/name/linnea.webp</file> | ||
| <file>imgs/char/name/lohen.webp</file> |
There was a problem hiding this comment.
The entry for lohen.webp is out of alphabetical order. It should be placed after lisa.webp (line 67) to maintain proper alphabetical sorting.
| <file>imgs/char/wish/lauma.webp</file> | ||
| <file>imgs/char/wish/layla.webp</file> | ||
| <file>imgs/char/wish/linnea.webp</file> | ||
| <file>imgs/char/wish/lohen.webp</file> |
There was a problem hiding this comment.
The entry for lohen.webp is out of alphabetical order. It should be placed after lisa.webp (line 67) to maintain proper alphabetical sorting.
| lauma = "Lauma" | ||
| layla = "Layla" | ||
| linnea = "Linnea" | ||
| lohen = "Lohen" |
There was a problem hiding this comment.
The enum member lohen is out of alphabetical order. It should be placed after lisa (line 83) to maintain proper alphabetical sorting.
gridhead
force-pushed
the
wild
branch
3 times, most recently
from
bbdb09d to
a7745f7
Compare
sdglitched
left a comment
sdglitched
left a comment
There was a problem hiding this comment.
Please make the changes.
| # TODO: Revise from Genshin Impact wiki page | ||
| ascn: BaseStat = BaseStat(attack=110.127410, defense=250.588883, health_points=4110.261000) |
There was a problem hiding this comment.
| # TODO: Revise from Genshin Impact wiki page | |
| ascn: BaseStat = BaseStat(attack=110.127410, defense=250.588883, health_points=4110.261000) | |
| ascn: BaseStat = BaseStat(attack=110.09981, defense=250.614, health_points=4110.59) |
Information is now available in Genshin Wiki
| 5779.197059142858, | ||
| 154.8139474571429, | ||
| 352.3375958428572, |
There was a problem hiding this comment.
| 5779.197059142858, | |
| 154.8139474571429, | |
| 352.3375958428572, | |
| 5779.31, | |
| 154.80, | |
| 352.35, |
Information is now available in Genshin Wiki
| 11953.987296, | ||
| 320.2325108, | ||
| 728.7933206, |
There was a problem hiding this comment.
| 11953.987296, | |
| 320.2325108, | |
| 728.7933206, | |
| 11954.32, | |
| 320.20, | |
| 728.82, |
Information is now available in Genshin Wiki
| 13314.32727, | ||
| 383.1889652, | ||
| 811.72847, |
There was a problem hiding this comment.
| 13314.32727, | |
| 383.1889652, | |
| 811.72847, | |
| 13314.66, | |
| 383.16, | |
| 811.75, |
Information is now available in Genshin Wiki
| 13771.777871999999, | ||
| 421.93346119999995, | ||
| 839.6176262, |
There was a problem hiding this comment.
| 13771.777871999999, | |
| 421.93346119999995, | |
| 839.6176262, | |
| 13772.11, | |
| 421.91, | |
| 839.64, |
Information is now available in Genshin Wiki
Co-authored-by: Akashdeep Dhar <akashdeep.dhar@gmail.com> Co-authored-by: Claude Code <noreply@anthropic.com>
2 participants
Introduce the recently added character
Lohento the rosterFixes #537