Skip to content

fix: config tests with runtimeConfig: false #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yinm wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −21
Open

fix: config tests with runtimeConfig: false #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50e02ac
fix: replace with a valid property
yinm Nov 8, 2024
bcde880
pnpm t -- -u
yinm Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions packages/core/src/__snapshots__/config.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,29 +37,22 @@ exports[`svgo async #loadConfig [async] should not load config with "runtimeConf
"dimensions": true,
"expandProps": "end",
"exportType": "default",
"icon": true,
"icon": false,
"index": false,
"memo": false,
"namedExport": "ReactComponent",
"native": false,
"noSemi": true,
"prettier": true,
"prettierConfig": undefined,
"ref": false,
"replaceAttrValues": [
[
"#063855",
"currentColor",
],
],
"runtimeConfig": true,
"replaceAttrValues": undefined,
"runtimeConfig": false,
"svgProps": undefined,
"svgo": true,
"svgoConfig": undefined,
"template": undefined,
"titleProp": false,
"typescript": false,
"useRuntimeConfig": false,
}
`;

Expand Down Expand Up @@ -156,29 +149,22 @@ exports[`svgo sync #loadConfig [sync] should not load config with "runtimeConfig
"dimensions": true,
"expandProps": "end",
"exportType": "default",
"icon": true,
"icon": false,
"index": false,
"memo": false,
"namedExport": "ReactComponent",
"native": false,
"noSemi": true,
"prettier": true,
"prettierConfig": undefined,
"ref": false,
"replaceAttrValues": [
[
"#063855",
"currentColor",
],
],
"runtimeConfig": true,
"replaceAttrValues": undefined,
"runtimeConfig": false,
"svgProps": undefined,
"svgo": true,
"svgoConfig": undefined,
"template": undefined,
"titleProp": false,
"typescript": false,
"useRuntimeConfig": false,
}
`;

Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ describe('svgo', () => {

it('should not load config with "runtimeConfig: false', async () => {
const config = await getMethod(loadConfig, mode)(
{ useRuntimeConfig: false },
{ runtimeConfig: false },
{ filePath: path.join(__dirname, '__fixtures__/svgr/icon.svg') },
)
expect(config).toMatchSnapshot()
Expand Down