fix: resolve race condition in anchor positioning for newly created anchors#244
Open
Antamansid wants to merge 1 commit intomainfrom
Open
fix: resolve race condition in anchor positioning for newly created anchors#244Antamansid wants to merge 1 commit intomainfrom
Antamansid wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Preview is ready. |
draedful
requested changes
Feb 16, 2026
|
|
||
| public $selected = computed(() => this.block.store.anchorSelectionBucket.isSelected(this.id)); | ||
|
|
||
| public $viewComponentReady = signal<boolean>(false); |
Collaborator
There was a problem hiding this comment.
If you want to watch to viewComponentReady state, you have to unset that state on unmount Anchor component
graph/src/components/canvas/anchors/index.ts
Line 172 in 642f27d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When creating new endpoints on HTML layer (zoomed-in React rendering), a race condition occurred between React and Canvas rendering cycles:
$anchorStatessignal changesSolution
Added a readiness signal to synchronize React and Canvas rendering:
$viewComponentReadysignaltruewhen Canvas anchor is initializedThis ensures React re-renders automatically when the Canvas component becomes available, eliminating the race condition without breaking encapsulation.