This repository was archived by the owner on Apr 6, 2021. It is now read-only.
-i to use public key instead of private key#40
Open
shadiakiki1986 wants to merge 3 commits intogravitational:masterfrom
Open
-i to use public key instead of private key#40shadiakiki1986 wants to merge 3 commits intogravitational:masterfrom
shadiakiki1986 wants to merge 3 commits intogravitational:masterfrom
Conversation
shadiakiki1986
changed the title
-i to use public key instead of private key
shadiakiki1986
changed the title
-i to use public key instead of private key
shadiakiki1986
changed the title
|
@webvictim this would be a great feature to have, can we merge this if possible? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. I wrote up some code to fix #19.
It deprecates using private keys in favor of using public keys.
The problem is that I could neither install the project dependencies, nor build it, nor run the tests.
I'm not sure if it's just something that I'm screwing up as I'm a golang newbie or something else.
I also tried adding some instructions in the readme about how to "build from source".
It would probably be a good idea to install dependencies via godep (example reference)
Edit 1: related to build fail: Issue #32 and #16
Edit 2: related issue to #19 is #9