Skip to content

fix(magento-product): count items with no customizable_options as added #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paales merged 1 commit into from
Jul 2, 2026
+7 −0
Merged

fix(magento-product): count items with no customizable_options as added #2641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/add-products-to-cart-empty-customizable-options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@graphcommerce/magento-product': patch
---

Fix the add-to-cart success message counting 0 when the added cart item has no `customizable_options` to match the requested entered/selected options against. `findAddedItems` now falls back to the SKU (+ configurable variant) match instead of dropping the item.
2 changes: 2 additions & 0 deletions packages/magento-product/components/AddProductsToCart/findAddedItems.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ export function findAddedItems(
}

const { customizable_options } = cartItem
// No customizable_options to match against — trust the SKU candidacy rather than drop the item.
if (customizable_options.length === 0) return true
const matchEntered = filterNonNullableKeys(itemVariable.entered_options).every(
(requestOption) =>
customizable_options.find(
Expand Down
Loading