Open
Conversation
Author
|
any update @sudo-rm-maker |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds configuration support for database table prefixes in the Gorse Helm charts. It enables users to specify custom naming prefixes for different types of database tables, improving multi-tenancy and database organization capabilities.
- Adds three new configuration parameters for table prefixes:
tablePrefix,cacheTablePrefix, anddataTablePrefix - Updates both regular Gorse and Gorse Enterprise charts with consistent configuration options
- Updates documentation to reflect the new configuration parameters
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/gorse/values.yaml | Adds database configuration section with table prefix parameters |
| charts/gorse/templates/configmap.yaml | Updates config template to use table prefix values from Helm values |
| charts/gorse/README.md | Documents the new table prefix configuration parameters |
| charts/gorse-enterprise/values.yaml | Adds same database configuration section for enterprise chart |
| charts/gorse-enterprise/templates/configmap.yaml | Updates enterprise config template with table prefix configuration |
| charts/gorse-enterprise/README.md | Documents table prefix parameters for enterprise chart |
Comments suppressed due to low confidence (2)
charts/gorse/README.md:89
- The parameter name 'databaseTablePrefix' in the documentation doesn't match the actual parameter name 'dataTablePrefix' used in values.yaml. This should be 'dataTablePrefix' for consistency.
| `gorse.database.databaseTablePrefix` | The naming prefix for tables (collections, keys) in data storage databases. | `""` |
charts/gorse-enterprise/README.md:43
- The parameter name 'databaseTablePrefix' in the documentation doesn't match the actual parameter name 'dataTablePrefix' used in values.yaml. This should be 'dataTablePrefix' for consistency.
| `gorse.database.databaseTablePrefix` | The naming prefix for tables (collections, keys) in data storage databases. | `""` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support to pass